gkellum: Author Summary
| Build | Completed | Comments | Test Results |
|---|---|---|---|
| LW-NIGHTLY-988 | 2 days ago |
[details]
LWC-4551 "NPE resuming video" - I added a check to see if the player is null.
LWC-4546 "NPE w/ video" -- A NPE was occurring when trying to resize the video container. So, I added some code that removes the resize listener when the video container is removed from the user interface.
LWC-4544 "IllegalArgument w/ video URIs" -- I'm now propogating an exception with converting the file name into a URL so that it causes a native video player to open.
A null pointer exception was occurring when the directory was null. So, I made some changes to allow null directories to be a valid value. (http://bugreports.limewire.com/bugs/searching.jsp?disp1=l&disp2=c&disp3=o&disp4=j&l=72&c=11&m=8_5891)
|
14 out of 3790 failed |
| LW-COMPONENTS-3208 | 3 days ago |
[details]
LWC-4544 "IllegalArgument w/ video URIs" -- I'm now propogating an exception with converting the file name into a URL so that it causes a native video player to open.
|
2 out of 1771 failed |
| LW-COMPONENTS-3207 | 3 days ago |
[details]
LWC-4546 "NPE w/ video" -- A NPE was occurring when trying to resize the video container. So, I added some code that removes the resize listener when the video container is removed from the user interface.
|
1770 passed |
| LW-UBUNTUREMOTEAGENT-865 | 3 days ago |
[details]
LWC-4544 "IllegalArgument w/ video URIs" -- I'm now propogating an exception with converting the file name into a URL so that it causes a native video player to open.
|
10 passed |
| LW-COMPILE-7338 | 3 days ago |
[details]
LWC-4544 "IllegalArgument w/ video URIs" -- I'm now propogating an exception with converting the file name into a URL so that it causes a native video player to open.
|
No tests found |
| LW-BITTORRENTWINDOWS-3120 | 3 days ago |
[details]
LWC-4544 "IllegalArgument w/ video URIs" -- I'm now propogating an exception with converting the file name into a URL so that it causes a native video player to open.
|
10 passed |
| LW-COMPONENTS-3206 | 3 days ago |
[details]
LWC-4544 "IllegalArgument w/ video URIs" -- The file name is now converted to a URL using File.getURI().getURL() rather than using the fmj conversion method.
|
1770 passed |
| LW-COMPILE-7336 | 3 days ago |
[details]
LWC-4546 "NPE w/ video" -- A NPE was occurring when trying to resize the video container. So, I added some code that removes the resize listener when the video container is removed from the user interface.
|
No tests found |
| LW-BITTORRENTWINDOWS-3117 | 3 days ago |
[details]
LWC-4546 "NPE w/ video" -- A NPE was occurring when trying to resize the video container. So, I added some code that removes the resize listener when the video container is removed from the user interface.
|
10 passed |
| LW-UBUNTUREMOTEAGENT-863 | 3 days ago |
[details]
LWC-4546 "NPE w/ video" -- A NPE was occurring when trying to resize the video container. So, I added some code that removes the resize listener when the video container is removed from the user interface.
|
10 passed |
| Build | Completed | Comments | Test Results |
|---|---|---|---|
| LW-COMPONENTS-3208 | 3 days ago |
[details]
LWC-4544 "IllegalArgument w/ video URIs" -- I'm now propogating an exception with converting the file name into a URL so that it causes a native video player to open.
|
2 out of 1771 failed |
| LW-NIGHTLY-983 | 1 week ago |
[details]
LWC-4511 "clicking on the close x in mac should not kill the program" -- I modified the osx close listener to only reject window close events. This allows the next listener in the chain to do saving and cleanup work when shutdowns are allowed.
LWC-4511 "clicking on the close x in mac should not kill the program" -- I fixed a problem with a zombie LimeWire window appearing when the user opens up about or preferences.
|
2 out of 3773 failed |
| LW-COMPONENTS-3182 | 1 week ago |
[details]
LWC-4511 "clicking on the close x in mac should not kill the program" -- I added an exit listener when the application is running on OS X that hides the application rather than closing it.
|
8 out of 1768 failed |
| LW-COMPONENTS-3110 | 3 weeks ago |
[details]
LWC-3220 "Not Connected Search Results Painting" - I added a gap between the search results message panel and the first line of search results, and I added some code to make the busy icon go away when sponsored search results appear.
|
2 out of 1800 failed |
| LW-COMPONENTS-3084 | 4 weeks ago |
[details]
LWC-3967 "If you multi-select files in your library and right click to delete in Mac OS-X it selects one file." -- There is a bug in Apple's implementation of JTable, where CTRL clicking on a table to simulate a right mouse click causes selected items in the table to be deselected. I created a proxy mouse listener that wraps Apple's Aqua mouse listener and doesn't pass it CTRL click events (or more exactly it doesn't pass it any events which are
popup triggers). This prevents Apple's implementation of JTable from improperly processing these events. |
2 out of 1796 failed |
| LW-COMPILE-7116 | 1 month ago |
[details]
LWC-4133 "On OS-X you cannot select multiple files or multiple directories when adding files to the library." -- We could switch to using JFileChooser to enable multiple selection, but JFileChooser's file navigation features are inferior to those of a native OS-X dialog. So, I expanded the existing native library, MacOSXUtils.m, to open up a native OS-X file dialog via Cocoa. This native dialog allows for multiple file or directory selections while also offering the file navigation features that OS-X users are used to.
|
No tests found |
| LW-COMPONENTS-3057 | 1 month ago |
[details]
LWC-2748 "why hyperlink does nothing" - I cleaned up the code a little bit based on the comments made during the code review.
|
2 out of 1796 failed |
| LW-COMPONENTS-3055 | 1 month ago |
[details]
LWC-2748 "why hyperlink does nothing" -- In ConnectionSummaryPanel there's a firewall transfer status text followed by a hyperlink. Users were misunderstanding how the hyperlink worked and thought it was broken. Roscoe suggested replacing the hyperlinked 'why' with a question mark icon that shows a popup when the user hovers over or clicks it. So, this is what I've done.
|
2 out of 1795 failed |
| LW-COMPILE-7086 | 1 month ago |
[details]
I removed the MRJAdapter jar, because it's no longer being used to provide access to OS-X events and menu items. Now, we're using com.apple.eawt.
|
No tests found |
| LW-COMPILE-7079 | 1 month ago |
[details]
LWC-4360 "convert mrjadapter to com.apple.eawt" -- I removed the references to MRJAdapter and replaced them with reference's to Apple's EAWT package. I checked in a stub jar as well to allow this code to compile without problems on other platforms.
|
No tests found |
| Build | Completed | Comments | Test Results |
|---|---|---|---|
| LW-COMPONENTS-3205 | 3 days ago |
[details]
A null pointer exception was occurring when the directory was null. So, I made some changes to allow null directories to be a valid value. (http://bugreports.limewire.com/bugs/searching.jsp?disp1=l&disp2=c&disp3=o&disp4=j&l=72&c=11&m=8_5891)
LWC-4548 "NPE finishing video" -- A NPE was occurring when the VideoDisplayDirector was checking to see which navigation panel the user was showing. I added a check for null to prevent this.
|
1770 passed |
| LW-COMPONENTS-3186 | 1 week ago |
[details]
LWC-4511 "clicking on the close x in mac should not kill the program" -- I modified the osx close listener to only reject window close events. This allows the next listener in the chain to do saving and cleanup work when shutdowns are allowed.
|
1770 passed |
| LW-NIGHTLY-982 | 1 week ago |
[details]
LWC-4457 "Video Player screen is cut off by LimeWire start-up mesage." -- I made some changes so that when the user previews a video, if the home panel is showing it switches to showing the library instead.
|
3769 passed |
| LW-BITTORRENTWINDOWS-3061 | 1 week ago |
[details]
LWC-3220 "Not Connected Search Results Painting" - Based on some advice from Michael T, I removed some unnecessary constructor arguments so that Guice can inject them instead.
|
10 passed |
| LW-COMPONENTS-3138 | 2 weeks ago |
[details]
LWC-4419 "Associate Magnet Links option missing on mac" -- I added a new class OSXUrlSchemeAssociation and made some changes in MacOSXUtils to support magnet links on OSX. I also changed the size of the options dialog to keep a warning message about file associations being overridden from being cut off, and I wrapped this message in html tags to make it multi-line when it exceeds a length that can fit in the panel. I also added a canUnregister method to the ShellAssociation class and implemented it in various subclasses so that we can tell if the association can be unregistered on the user's operating system.
LWC-4345 -- Rename shared files on iTunes to "name's LimeWire Files" instead of "name's tunes"
LWC-4418 "UI Issue with Browse Friends Files (Mac)" -- Some changes I made in SearchResultsPanel distorted the user message that is shown when a user chooses to browse through a friend's files and no friends are connected. So, I changed the way that this user message is set by making it an overlay in SearchResultsPanel, and I moved the existing overlay for the "awaiting connections" message into SearchResultsPanel as well. So, now, the same overlay is used for both of these messages.
LWC-4449 "Fix Mac Full Screen" -- I removed an unnecessary key listener.
|
1760 passed |
| LW-UBUNTUREMOTEAGENT-677 | 3 weeks ago |
[details]
LWC-4377 "On OS-X exceptions are occuring in the dock library, which may be interferring with proper control of the OS-X dock" -- On OS-X I have been seeing sporadic error messages coming from the native library controlling the dock such as "CGContextDrawImage: invalid context 0x0". I looked into the code in this library and Apple's documentation, and Apple recommends placing the code for updating the dock in a custom view which gets called by the system after the system does a lot of work in advance including setting up the context for drawing. The code in the dock was not placed in such a view and set-up work of creating the drawing context was not always being done before the dock library started trying to update the dock, which caused the error messages I was seeing . So, I moved the existing code into a custom view, and now the Cocoa equivalent of repaint() is being called on this view so that it's "paint" method is being called only after a drawing context has been created.
|
10 passed |
| LW-COMPILE-7117 | 1 month ago |
[details]
Added a dependency to the foxtrot jar.
|
No tests found |
| LW-COMPONENTS-3058 | 1 month ago |
[details]
LWC-4016 "Options contextual menu on mac is not aligned" -- On OSX menus with submenus were being highlight in blue and simple menu items were being highlighted in lime green. Also, they had different indentation amounts. So, I set a property to have Swing use the BasicMenuUI rather than the AquaMenuUI, and I attached the lime green color to it as the selection color.
|
1795 passed |
| LW-COMPONENTS-3050 | 1 month ago |
[details]
LWC-3416 - "Allow Option in Mac version to associate torrents" -- I expanded the existing native library, MacOSXUtils, by adding some methods for querying the current default launcher for a particular file type as well as changing it. And I created a new Java class, OSXFileTypeAssociation, that uses this functionality and fits in the existing architecture in LimeWire for associating particular file types with LimeWire.
|
1795 passed |
| LW-COMPILE-7088 | 1 month ago |
[details]
I removed some references to MRJAdapter.
|
No tests found |